Add tagger tags to pod manifests #31565

aureleoules · 2024-11-28T13:17:38Z

What does this PR do?

The manifest payloads have already had a tags field added to the payloads - but we need to add all the tags to the individual manifest the agent would normally send to only the orch track to the orchmanif track too.

I tested that it works on my local minikube cluster.

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2024-11-28T14:07:14Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50562623 --os-family=ubuntu

Note: This applies to commit 8011703

cit-pr-commenter · 2024-11-28T14:30:18Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8d38b985-9aea-4deb-94a8-2cc559beca15

Baseline: 623bea0
Comparison: 623bea0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.20	[+1.48, +2.93]	1	Logs
➖	otel_to_otel_logs	ingress throughput	+2.06	[+1.35, +2.77]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.28	[-0.19, +0.74]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.25	[-0.55, +1.04]	1	Logs
➖	quality_gate_idle	memory utilization	+0.23	[+0.19, +0.27]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.20	[+0.07, +0.32]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.16	[+0.04, +0.28]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.02	[-0.61, +0.66]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.06, +0.10]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.75, +0.72]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.05	[-0.81, +0.72]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.05	[-0.82, +0.73]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.12	[-0.91, +0.67]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.15	[-0.98, +0.68]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.48	[-0.55, -0.41]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.51	[-4.42, +1.40]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency_http2	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

go.mod

aureleoules · 2024-12-09T11:26:43Z

/merge

dd-devflow · 2024-12-09T11:26:54Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-09 11:26:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-09 15:27:07 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

pkg/collector/corechecks/cluster/orchestrator/processors/k8s/pod.go

aureleoules · 2024-12-09T15:19:02Z

/merge

dd-devflow · 2024-12-09T15:20:12Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-09 15:20:12 UTC ❌ MergeQueue

PR already in the queue with status waiting

aureleoules · 2024-12-09T16:14:38Z

/merge

dd-devflow · 2024-12-09T16:15:42Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-09 16:15:42 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-09 20:15:31 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

aureleoules · 2024-12-10T10:00:20Z

/merge

dd-devflow · 2024-12-10T10:00:34Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-10 10:00:33 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-10 14:00:36 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

aureleoules · 2024-12-11T10:35:12Z

/merge

dd-devflow · 2024-12-11T10:35:21Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-11 10:35:20 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

2024-12-11 11:07:32 UTC ℹ️ MergeQueue: This merge request was merged

github-actions bot added medium review PR review might take time team/container-app labels Nov 28, 2024

aureleoules force-pushed the CAP-1995-agent-Add-tags-from-the-common-tagger-to-all-manifest-payloads branch from 5315a8a to 6efe568 Compare November 28, 2024 13:38

aureleoules changed the title ~~collect pod tagger tags~~ Add tagger tags to pod manifests Nov 28, 2024

aureleoules marked this pull request as ready for review November 28, 2024 14:42

aureleoules requested review from a team as code owners November 28, 2024 14:42

aureleoules commented Nov 28, 2024

View reviewed changes

go.mod Outdated Show resolved Hide resolved

kangyili approved these changes Nov 28, 2024

View reviewed changes

kayayarai approved these changes Nov 28, 2024

View reviewed changes

aureleoules force-pushed the CAP-1995-agent-Add-tags-from-the-common-tagger-to-all-manifest-payloads branch from d25cfb7 to 10beced Compare November 29, 2024 09:02

aureleoules force-pushed the CAP-1995-agent-Add-tags-from-the-common-tagger-to-all-manifest-payloads branch 2 times, most recently from 1fa6f5b to d938099 Compare December 9, 2024 09:41

aureleoules requested review from a team as code owners December 9, 2024 10:23

aureleoules requested a review from mx-psi December 9, 2024 10:23

github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Dec 9, 2024

aureleoules added 3 commits December 9, 2024 11:37

Collect pod tags in manifests

72b1dea

Add release note

49ce7cd

bump agent-payload

ce741b2

aureleoules force-pushed the CAP-1995-agent-Add-tags-from-the-common-tagger-to-all-manifest-payloads branch from 4cad0be to ce741b2 Compare December 9, 2024 10:39

github-actions bot added medium review PR review might take time and removed long review PR is complex, plan time to review it labels Dec 9, 2024

KevinFairise2 removed the request for review from a team December 9, 2024 10:42

inv tidy

fc9c0b1

github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Dec 9, 2024

aureleoules added the qa/done QA done before merge and regressions are covered by tests label Dec 9, 2024

remeh reviewed Dec 9, 2024

View reviewed changes

pkg/collector/corechecks/cluster/orchestrator/processors/k8s/pod.go Outdated Show resolved Hide resolved

Check type cast

8011703

mackjmr approved these changes Dec 9, 2024

View reviewed changes

mackjmr removed the request for review from mx-psi December 9, 2024 13:08

kkhor-datadog approved these changes Dec 9, 2024

View reviewed changes

remeh approved these changes Dec 9, 2024

View reviewed changes

KevinFairise2 approved these changes Dec 11, 2024

View reviewed changes

dd-mergequeue bot merged commit 623bea0 into main Dec 11, 2024
400 checks passed

dd-mergequeue bot deleted the CAP-1995-agent-Add-tags-from-the-common-tagger-to-all-manifest-payloads branch December 11, 2024 11:07

github-actions bot added this to the 7.62.0 milestone Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tagger tags to pod manifests #31565

Add tagger tags to pod manifests #31565

aureleoules commented Nov 28, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Nov 28, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 28, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

aureleoules commented Dec 9, 2024

dd-devflow bot commented Dec 9, 2024 •

edited

Loading

aureleoules commented Dec 9, 2024

dd-devflow bot commented Dec 9, 2024 •

edited

Loading

aureleoules commented Dec 9, 2024

dd-devflow bot commented Dec 9, 2024 •

edited

Loading

aureleoules commented Dec 10, 2024

dd-devflow bot commented Dec 10, 2024 •

edited

Loading

aureleoules commented Dec 11, 2024

dd-devflow bot commented Dec 11, 2024 •

edited

Loading

Add tagger tags to pod manifests #31565

Add tagger tags to pod manifests #31565

Conversation

aureleoules commented Nov 28, 2024 • edited Loading

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Nov 28, 2024 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Nov 28, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

aureleoules commented Dec 9, 2024

dd-devflow bot commented Dec 9, 2024 • edited Loading

Devflow running: /merge

aureleoules commented Dec 9, 2024

dd-devflow bot commented Dec 9, 2024 • edited Loading

Devflow running: /merge

aureleoules commented Dec 9, 2024

dd-devflow bot commented Dec 9, 2024 • edited Loading

Devflow running: /merge

aureleoules commented Dec 10, 2024

dd-devflow bot commented Dec 10, 2024 • edited Loading

Devflow running: /merge

aureleoules commented Dec 11, 2024

dd-devflow bot commented Dec 11, 2024 • edited Loading

Devflow running: /merge

aureleoules commented Nov 28, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Nov 28, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 28, 2024 •

edited

Loading

dd-devflow bot commented Dec 9, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Dec 9, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Dec 9, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Dec 10, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Dec 11, 2024 •

edited

Loading

Devflow running: `/merge`